Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running python3 build.py gives an error at the very end a file license.py is missing #2871

Open
3 tasks done
Jazzykhan opened this issue May 19, 2024 · 7 comments
Open
3 tasks done
Labels

Comments

@Jazzykhan
Copy link

OS/Platform

Windows

Installed

Compiled from source

Version

125.0

Have you tested that this is not an upstream issue or an issue with your configuration?

  • I have tried reproducing this issue in Chrome and it could not be reproduced there
  • I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
  • I have tried reproducing this issue in ungoogled-chromium with a new and empty profile using --user-data-dir command line argument and it could not be reproduced there

Description

Giving error on the end

How to Reproduce?

Follow all steps and then run python3 build.py and wait for many many hours lol just to know there is an error

0deed6e8-008c-4a38-90e6-071649629df7

Actual behaviour

Error at the end

Expected behaviour

No error

Relevant log output

No response

Additional context

No response

@Jazzykhan Jazzykhan added the bug label May 19, 2024
@Nifury
Copy link
Member

Nifury commented May 19, 2024

These are more like warnings and don't affect your compilation.

It's likely an upstream issue: https://issues.chromium.org/issues/333628466

@Jazzykhan
Copy link
Author

But if i run package.py it gives error no mini installer found am i missing something?

Uploading 6badce0b-a3d5-472f-b7ed-a84683854dd8.jpeg…

@Nifury
Copy link
Member

Nifury commented May 19, 2024

You might have either run package.py twice (package.py deletes mini_installer.exe), or you compiled with the --ci flag which automatically runs package.py.

@Jazzykhan
Copy link
Author

So now if i edit code and run build.py again it should not make all 61k files again right? But it is doing it again :(

@Nifury
Copy link
Member

Nifury commented May 19, 2024

Well it depends on how you edit the code. The easiest way is to run python3 build.py --ci, and only the installer will be built.

@Jazzykhan
Copy link
Author

and if want to build a portable version like files only how to build that and where it will be built ?

@Nifury
Copy link
Member

Nifury commented May 20, 2024

https://github.com/ungoogled-software/ungoogled-chromium-windows?tab=readme-ov-file#building-1

A zip archive and an installer will be created under build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants