GNU 13.2.0 via Ubuntu 24.04 gives [-Wnonnull] warnings for RC_2_0 branch.

[xavier2k6]

Please provide the following information

libtorrent version (or branch): RC_2_0

platform/architecture: Ubuntu 24.04 LTS (Noble Numbat)

compiler and compiler version: GNU 13.2.0

---

Was building qBittorrent with recently released github runner image of Ubuntu 24.04 & came across below:

---

[-Wnonnull]

warning: argument 1 null where non-null expected [-Wnonnull]

2024-05-14T22:37:34.3686907Z [85/168] Building CXX object CMakeFiles/torrent-rasterbar.dir/src/posix_storage.cpp.o
2024-05-14T22:37:34.3696346Z /home/runner/work/qBittorrent/libtorrent/src/posix_storage.cpp:53:28: warning: argument 1 null where non-null expected [-Wnonnull]
2024-05-14T22:37:34.3698120Z    53 | static_assert(sizeof(ftello(nullptr)) >= 8, "64 bit file operations are required");
2024-05-14T22:37:34.3699117Z       |                      ~~~~~~^~~~~~~~~
2024-05-14T22:37:34.3699801Z In file included from /usr/include/features.h:502,
2024-05-14T22:37:34.3700820Z                  from /usr/include/x86_64-linux-gnu/c++/13/bits/os_defines.h:39,
2024-05-14T22:37:34.3701922Z                  from /usr/include/x86_64-linux-gnu/c++/13/bits/c++config.h:679,
2024-05-14T22:37:34.3702729Z                  from /usr/include/c++/13/cstddef:49,
2024-05-14T22:37:34.3703995Z                  from /home/runner/work/qBittorrent/libtorrent/include/libtorrent/config.hpp:50,
2024-05-14T22:37:34.3705386Z                  from /home/runner/work/qBittorrent/libtorrent/src/posix_storage.cpp:35:
2024-05-14T22:37:34.3710550Z /usr/include/stdio.h:815:18: note: in a call to function ‘__off64_t ftello(FILE*)’ declared ‘nonnull’
2024-05-14T22:37:34.3711762Z   815 | extern __off64_t __REDIRECT (ftello, (FILE *__stream), ftello64)
2024-05-14T22:37:34.3712489Z       |                  ^~~~~~~~~~
2024-05-14T22:37:41.3384877Z [86/168] Building CXX object CMakeFiles/torrent-rasterbar.dir/src/read_resume_data.cpp.o

CMake Warning:

2024-05-14T22:35:36.3914005Z CMake Warning (dev) at cmake/Modules/LibtorrentMacros.cmake:43 (find_package):
2024-05-14T22:35:36.3915194Z   Policy CMP0144 is not set: find_package uses upper-case <PACKAGENAME>_ROOT
2024-05-14T22:35:36.3916511Z   variables.  Run "cmake --help-policy CMP0144" for policy details.  Use the
2024-05-14T22:35:36.3917612Z   cmake_policy command to set the policy and suppress this warning.

See logs from github action:

logs_23787166436.zip

@arvidn Note: there are other warnings/deprecations for RC_1_2 branch, you can have a look through action build via https://github.com/xavier2k6/qBittorrent/actions/runs/9087059188