Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Perfect FLAC definition as used by RED #1494

Open
frantathefranta opened this issue Apr 8, 2024 · 3 comments
Open

Add Perfect FLAC definition as used by RED #1494

frantathefranta opened this issue Apr 8, 2024 · 3 comments
Labels
Feature request New features, improvements etc filters Filters

Comments

@frantathefranta
Copy link

Is your feature request related to a problem? Please describe.
When using a Music oriented filter, the helpful "Perfect FLAC" override is different in definition than what the Redacted tracker uses. Redacted states that "(100% log for CD, or any Vinyl/DVD/Soundboard/WEB/Cassette/Blu-ray/SACD/DAT)" counts for a Perfect FLAC. I realize that autobrr uses the Orpheus definition, which I respect.

Describe the solution you'd like
I'd like to have an option to select the Redacted definition.

Describe alternatives you've considered
If it's not possible to do this, I'd like to know how to set up a filter that covers the Redacted definition of Perfect FLAC, as when I try to select it manually in the simple toggles, I can't get it to snatch both WEB FLACs and CD FLACs with 100% log.

@frantathefranta frantathefranta added the Feature request New features, improvements etc label Apr 8, 2024
@zze0s
Copy link
Collaborator

zze0s commented Apr 10, 2024

Hi! I think we use the varroa definition of Perfect FLAC which is CD, FLAC, Lossless/24bit lossless, Cue file, Log file, Log Score 100%.

You should be able to setup a filter for that:

{
    "name": "Music",
    "version": "1.0",
    "data": {
        "formats": [
            "FLAC"
        ],
        "quality": [
            "Lossless",
            "24bit Lossless"
        ],
        "media": [
            "CD",
            "WEB",
            "Vinyl",
            "Soundboard",
            "DAT",
            "Cassette",
            "Blu-Ray",
            "SACD"
        ],
        "cue": true,
        "log": true,
        "log_score": 100
    }
}

We can look into if the predefined Perfect FLAC setting should be changed, but I am a bit hesitant as there are a lot of users relying on it that might start to get unwanted releases after a change like that.

@zze0s zze0s added the filters Filters label Apr 10, 2024
@frantathefranta
Copy link
Author

Yeah I definitely don't want to break it for anyone. I feel like I've tried this and it didn't grab Lossless WEB files, but I'll try again.

@zze0s
Copy link
Collaborator

zze0s commented Apr 11, 2024

Please do and set your log level in settings to either Debug or Trace for like a day and see what it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New features, improvements etc filters Filters
Projects
None yet
Development

No branches or pull requests

2 participants