[BUG] Changing server name shows button "failure" instead of "saving..."

[reloxx13]

When i edit a server name and hit save, instead of "saving..", the button shows failure till the server page gets reloaded.

The save is successfull, just the button text is wrong.

[Safihre]

I can't reproduce it on my machine. Are you on 3.0.0?
Does this also happen on a different browser?

[reloxx13]

Heya,
Checked chrome and edge, both work fine.

Just happens in latest Firefox 🙄

disabled theme and adblocker in ff and still happens.

sabnzbd 3.0.0rc1

[thezoggy]

I can confirm this happens as well with firefox 78.0.1 and windows binary 3.0rc1
I suspect this is fallout from upgrading to jquery 3.x as our version of jquery-form is a bit dated and needs updating to support 3.x -- https://github.com/jquery-form/form

Hard to confirm however since I'm not running from source on this box just yet so I cant just swap it out and confirm myself

[Safihre]

The update of jquery-form didn't fix it.
Probably have to lower the jQuery version again..

[Safihre]

Oh, seems this was broken for 3 years already since we started using jQuery 3.

[thezoggy]

do you know why we even use it? (as it seems like its just for lazy coders to do ajax)

[Safihre]

No clue, it's been there before I joined SABnzbd 😃 Last I can find is when you copied it from the submodule
https://github.com/sabnzbd/sabnzbd/blame/102eaa966ba1c1fd0c1c26838653a7115fb16145/interfaces/Config/README.txt#L7-L21

[Safihre]

Seems you added it 😉
https://github.com/thezoggy/sabnzbd-uni_Config/blame/master/templates/_inc_header_uc.tmpl#L66-L70
And now, I am too lazy to remove it.. true 😃

[thezoggy]

i know i used it in the universal config.. but i could have sworn that it was just a carry over from whatever skin I copied some stuff from. back in the day each skin had its own config.. it got annoying to update all of them anytime you wanted to make a change.

if it really was me, damn i should be slapped :P but right now the page just re-loads which funny enough was the 'fix' about the last time this utility was mentioned: #398

so if its broken we might as well just remove it and call it a day until everything gets re-written to be proper ajax handling

[Safihre]

We only refresh the page if the name or priority changes, otherwise it's the ajax-form. So since this bug has been there for 3 years I'm fine to leave it for now.
I also don't think the backend has changed much since you made the Config, it's such a mess in interface.py it's scary... 👻

[Safihre]

@thezoggy feel free to fix 👍