Replace cherrypy by something new

[Safihre]

cherrypy has not really been updated since 2019.

I was looking into replacing it with starlette and uvicorn, which use Python's async framework.

It would require a major rewrite of all interface code, so it might not be worth it.
In the end we do not care that much about thousands of concurrent transactions and mostly SABnzbd's own code is the bottleneck.

[thezoggy]

i would vote for using uvicorn for server, fastapi for api (which is built ontop of starlette, and uses pydantic for validation)
then automatic api tests using schemathesis/dredd

but web framework+api side, there is prob a bit of things we could optimize within sab code as you noted.
one example off the top of my head is all our uses for urllib, we could use requests instead.

[Safihre]

@thezoggy You mentioned the urllib part a number of times, but the only real place where we really use it a lot is in the URLGrabber, and that code is not overly complicated because of urllib use.

Will take a look at fastapi!

[thezoggy]

I recently picked this up, so far has been a good read:
https://livebook.manning.com/book/microservice-apis-in-python/

[Safihre]

After implementing, double check errors like: #2267.

[Safihre]

@jcfp any chance I can interest you in this? 😊 You know how to handle big impact projects like replacing the Sorter!
I already made a POC start: https://github.com/sabnzbd/sabnzbd/tree/feature/uvicorn

We can also consider dropping functionality (like supporting both http and https simultaneously on different ports, as an example) if they turn out too complicating.

It seems cherrypy is really not maintained anymore.

[jcfp]

I'll take a look

[thezoggy]

wow, cheroot finally pulled in that ssl pr. hopefully new cherrpy soon

[Safihre]

Hopefully, although I still want to rip it out as soon as possible. It's close to abandonware, although Cheetah is probably worse..