Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rarfile.py #2560

Open
thezoggy opened this issue May 12, 2023 · 3 comments
Open

update rarfile.py #2560

thezoggy opened this issue May 12, 2023 · 3 comments

Comments

@thezoggy
Copy link
Contributor

our util/rarfile.py is version 3.0 from 2016, latest release was 4.0 from 2020.
https://github.com/markokr/rarfile/releases/tag/v4.0

While our version works there has been a few updates to upstream repo (add sfx, support longer than 28char passwords, drop python2 support, python3 related updates to leverage newer libs and streamlines things some more with hashlib).

list of changes:
https://github.com/markokr/rarfile/blob/master/doc/news.rst

@Safihre
Copy link
Member

Safihre commented May 13, 2023

I know, but his changes made some of our required patches very hard to apply again.
So there was this issue:
markokr/rarfile#56
And then this, so we wouldn't need to vendor rarfile anymore:
markokr/rarfile#74

I guess I can just give up and vendor it again.

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues automatically closed because they became stale label Jun 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
@Safihre Safihre reopened this Sep 19, 2023
@Safihre
Copy link
Member

Safihre commented Sep 19, 2023

Finally he released a new version with the needed patches.

@Safihre Safihre added Feature request and removed Stale Issues automatically closed because they became stale labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants