Explicitly Setting $whatif = $false Prevents Module Installation

[milosbithawk]

Prerequisites

• Write a descriptive title.
• Make sure you are able to repro it on the latest released version
• Search the existing issues.

Steps to reproduce

When using PowerShell 7.5 with Microsoft.PowerShell.PSResourceGet (version 1.1.1), explicitly setting $whatif to $false prevents the module from being installed
Example:
$whatif=$false
Install-PSResource -Name Microsoft.Entra -WhatIf:$whatif -Scope AllUsers

• PowerShell 5.1 Behavior – Module Installs as Expected
  Install-Module -Name Microsoft.Entra -WhatIf:$whatif -Scope AllUsers -AllowClobber

Expected behavior

The Module should be installed.

Actual behavior

The module is not getting installed

Error details

No error message generated

Environment data

Name                           Value
----                           -----
PSVersion                      7.5.0
PSEdition                      Core
GitCommitId                    7.5.0
OS                             Microsoft Windows 10.0.26100
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visuals

[sdwheeler]

This is the same problem with other cmdlets that was reported in PowerShell/PowerShell#25015. The logic for testing switch parameters is not correct.

[sdwheeler]

The problem is here:

PSResourceGet/src/code/InstallHelper.cs

Line 675 in 89ca445

if (_cmdletPassedIn.MyInvocation.BoundParameters.ContainsKey("WhatIf"))

Besides testing for the parameter set or if the parameter exists, it should also test the value of the parameter.

[surfingoldelephant]

This is also ignored:

Register-PSResourceRepository -PSGallery:$false

I can create a separate issue for this if desired. Or perhaps this current issue can be repurposed to address all instances of the problem in PSResourceGet.

[sdwheeler]

I think the current issue is enough. They need to look at all SwitchParamter instances.