You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However doing this (since it's .NET Core) if the project uses source link, it would result in various warnings when building saying it cannot read the .git directories of the clones.
A cleaner aproach to this I would prefer more than this would be a simple actions/checkout@v2 step that then sets parent: 'Elskom/Sdk'
So then the checkout action would look at it (default to that is null), and if it's not null or empty, check it out first, then check out the other repository like normally.
Something would need to be done on this action to somehow fix sourcelink's complaining though.
Bonus Points: Do not emit this to <subproject repo name><subproject repo name>/<parent project repo name> and instead of <parent project repo name>/<parent project repo name> at least.
The reason why as to this is an issue as it wastes valuable build time doing them separate and then it tries to clear out the specific directories that are being cloned too.
Alternatively, in this case the action could recursively clone the parent, then check out the commit to the subproject like normally and avoid the clear out on it in terms of the files, however it would mean also adding a variable to tell the action where the submodule is located at in said project so it can check out the commit of that specific project.
The text was updated successfully, but these errors were encountered:
Currently one has to do this within a subproject in order to build it if the subproject requires files from the parent project to be cloned first
https://github.com/Elskom/zlib.managed/blob/main/.github/workflows/dotnetcore-build.yml#L15-L24
However doing this (since it's .NET Core) if the project uses source link, it would result in various warnings when building saying it cannot read the
.git
directories of the clones.A cleaner aproach to this I would prefer more than this would be a simple
actions/checkout@v2
step that then setsparent: 'Elskom/Sdk'
So then the checkout action would look at it (default to that is null), and if it's not null or empty, check it out first, then check out the other repository like normally.
Something would need to be done on this action to somehow fix sourcelink's complaining though.
Bonus Points: Do not emit this to
<subproject repo name><subproject repo name>/<parent project repo name>
and instead of<parent project repo name>/<parent project repo name>
at least.The reason why as to this is an issue as it wastes valuable build time doing them separate and then it tries to clear out the specific directories that are being cloned too.
Alternatively, in this case the action could recursively clone the parent, then check out the commit to the subproject like normally and avoid the clear out on it in terms of the files, however it would mean also adding a variable to tell the action where the submodule is located at in said project so it can check out the commit of that specific project.
The text was updated successfully, but these errors were encountered: