Skip to content

DBLink has styles for variant "inline", but no Typescript definitions or documentation for it #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 7 tasks
milan-w opened this issue Apr 1, 2025 · 0 comments
Open
1 of 7 tasks
Labels

Comments

@milan-w
Copy link

milan-w commented Apr 1, 2025

Which generators are impacted?

  • All
  • HTML
  • React
  • Angular
  • Vue
  • Web components
  • Power Apps

Reproduction case

https://marketingportal.extranet.deutschebahn.com/marketingportal/Design-Anwendungen/db-ux-design-system/version-3/components/link#10447656

Laut Doku gibt es für die Komponente DBLink nur noch die Varianten "adaptive" und "brand". Im CSS für DBLink steht aber:

%db-default-link {
    &:not([data-variant="inline"]) {
      white-space: nowrap;
    }
    &[data-variant="inline"] {
      display: inline;
    }
...
}

source: packages/components/src/styles/internal/_link-components.scss

Zusätzlich findet sich dort die Definition %db-link-height, die dafür sorgt, dass alle .db-link Komponenten eine fixe block-size also Höhe bekommen:

%db-link-height {
	display: inline-block;
	block-size: variables.$db-sizing-sm;
}

Da es nicht unüblich ist, dass verlinkte Text auch mal umbrechen, sollte die Anwendung dieser fixe Höhe mindestens optional sein.

Expected Behaviour

Either I'm able to use data-variant="inline" or the "inline" styles are applied when using data-variant="adaptive".

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants