Open
Description
Checks
- I've already read https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/troubleshooting-actions-runner-controller-errors and I'm sure my issue is not covered in the troubleshooting guide.
- I am using charts that are officially provided
Controller Version
0.12.1
Deployment Method
Helm
Checks
- This isn't a question or user support case (For Q&A and community support, go to Discussions).
- I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
To Reproduce
1. Create a `values.yaml` file with
template:
spec:
imagePullSecrets:
- image-pull-secret-1
- image-pull-secret-2
2. Apply the values with `helm install -f values.yaml gha-runner-scale-set`
3. You will see an error of `nable to retrieve some image pull secrets (image-pull-secret-1,image-pull-secret-2); attempting to pull the image may not succeed.` and the listener image will fail to pull.
If you look the custom resource for the listener (autoscalinglisteners), you will see that under `spec.imagePullSecrets` it will be set to `- name: image-pull-secret-1,image-pull-secret-2`. Edit it to be
- name: image-pull-secret-1
- name: image-pull-secret-2
and the listener will work correctly.Describe the bug
When providing multiple imagePullSecrets for the gha-runner-scale-set helm chart, they get combined in a comma separated string rather than going to new lines.
Describe the expected behavior
The created custom resource should be
- name: image-pull-secret-1
- name: image-pull-secret-2Additional Context
Example values.yaml file
template:
spec:
imagePullSecrets:
- name: image-pull-secret-1
- name: image-pull-secret-2Controller Logs
https://gist.github.com/Cyb3r-Jak3/432fde866878fcfe1184e286db85efcaRunner Pod Logs
https://gist.github.com/Cyb3r-Jak3/4ac922be841970106bb3fd23769dcc81