Skip to content

Incorrectly detecting change of zeroes in decimal place #260

Open
@Liamhanninen

Description

@Liamhanninen

First of all this library has been so useful. It's exactly what I needed and works really well. There is only one issue.
It seems to be detecting changes that aren't occurring. At first I thought the model was adding zeros or the db was removing them. But after some digging I think it's a bug with django-auditlog.
It thinks a change occurred anytime I save this record: it thinks that I started with .00 and changed it to .0. But .00 is the existing value and I didn't change anything. I just saved() the record.
image
I checked the output of the form itself in the clean() method:

services_sub_total
44.00
sum_payments
33.00

And then in the database:
image
I just cant figure out where/why this is detecting only one zero in the decimal place - I'm not seeing that .0 anywhere.
Could the delta functions be truncating multiple zeros in the decimals to .0?

Activity

iklinac

iklinac commented on Sep 2, 2020

@iklinac

As already responded to SO question

If you look up into source you would see that it compares these two values not as field values but through use of smart_text values are converted to string inside get_field_value

So it basically compares "44.00" and your value of "44.0" and this is different string so it is triggered as change

Not sure if this is by design as in my eyes would be considered bug

Liamhanninen

Liamhanninen commented on Sep 3, 2020

@Liamhanninen
Author

Thanks for digging into that and providing the file and line! I will hack it for now. Hopefully it is fixed here (I'm sure my way will not be the best).

linked a pull request that will close this issueFix trailing zeros in decimal #261on Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @iklinac@Liamhanninen

      Issue actions

        Incorrectly detecting change of zeroes in decimal place · Issue #260 · jazzband/django-auditlog