Open
Description
If you use a custom user that does not include first_name
/ last_name
as a field, searching in the admin will error out as actor__first_name
and actor__last_name
are not valid fields.
I can think of a few options:
- Unregister the admin using
admin.site.unregister(LogEntry)
- Subclass
LogEntryAdmin
, overridesearch_fields
- Register this new admin.
Or simply remove these fields from the built-in admin search_fields
.
Or only add these to search if get_user_model
+ meta ensures they exist.
I generally avoid splitting up first name / last name these days, though I know Django defaults to this.
Let me know which option sounds reasonable and I'm happy to open a PR. Great project, saved me a lot of time. Thanks.
Activity
[-]Document or remove first_name / last_name as a search in the admin[/-][+]Document or remove first_name / last_name as a search in the admin for custom users[/+]aleh-rymasheuski commentedon Feb 9, 2023
@silviogutierrez, the option to ensure that
first_name
&last_name
fields exists makes the most sense to me. I think we can defineget_search_fields
method onLogEntryAdmin
which will inspect the user model and exclude any of the two fields if they are not defined.hramezani commentedon Feb 10, 2023
Thanks @silviogutierrez for the issue.
Agree with @alieh-rymasheuski,
get_search_fields
sounds good to me