Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support devEngines field in package.json #1255

Open
zanminkian opened this issue Mar 21, 2025 · 2 comments
Open

Support devEngines field in package.json #1255

zanminkian opened this issue Mar 21, 2025 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@zanminkian
Copy link

zanminkian commented Mar 21, 2025

Description:
devEngines field is now supported by npm and corepack.

If user set node-version-file: package.json in yaml, setup-node action should consult both engines and devEngines fields, while currently only engines works.

Justification:
In monorepo, the root package.json usually have no engines field. Moreover, the engines is for users who install the npm package, while the devEngines field is for who developers who develop the npm package. Obviously, devEngines is more suitable for setup-node.

Are you willing to submit a PR?
Yes

@zanminkian zanminkian added feature request New feature or request to improve the current logic needs triage labels Mar 21, 2025
@suyashgaonkar
Copy link
Contributor

Hi @zanminkian , Thank you for creating this feature request. We will investigate it and provide feedback as soon as we have some updates.

@mklueh
Copy link

mklueh commented Apr 13, 2025

And if anyone is working on this, maybe you could also consider factoring in the volta node field?

Image

Then you could run volta pin node@23.11.0 which would fetch and install node, set the node version in package.json volta.node and that's all you have to do

https://docs.volta.sh/reference/pin

But maybe it would be better to let volta handle the devEngines update instead of making this action volta-aware

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants