-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Switch from Jest to Node.js's Native Test Runner #6123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue is open to grabs by anyone interested :) |
Hey ! I'm trying to work on this but I got a problem. It's because node doesn't found ts file. So should we build ts before test ? |
No. You want to use node --loader=ts-node/esm Node.js supports custom loaders. (You need to add ts-node as a dev dependency btw) |
Or if you also need react compatibility. You might want to use the tsx loader (also a package) |
hummm interessing |
Have you considered ditching JSDOM + RTL in favor of Cypress/Playwright Component Testing? |
We already have Visual Regression Testing. The only tests we have for Components at the moment are for specific states. And no, we dont want yet another tool and library and platform. Thank you. |
To clarify, our testing of components here is really bare bones, just to certify that for example, a select actually renders said items. Adding browser testing (even if headless) is overkill for our needs. So pretty much Node.js itself provides everything we need here with its native test runner; + we only want to unit test utilities, helpers, hooks and certain components that are stateful. Everything else is already covered by Chromatic + Storybook |
@AugustinMauroy are you still working on this? |
@araujogui I'm stuck in my pr with the dom. If you want you can commit on my pr it is in "allow edit by maintainer" so in theory you could commit. It's up to you to finish it 😁 |
@AugustinMauroy can you share the link on PR? |
its linked above #6129 |
NEWS:
|
I would like to contribute (first time to this repo, Hello 👋🏻), but I can't see the PR @AugustinMauroy. Can you share the link so maybe I can run it locally and potentially review it to start familiarising myself with the code? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@ovflowd This task is still looking for some help? |
@AugustinMauroy How is your progress on this coming along? |
Now you're going to laugh, but I had some local changes that I deleted during my tailwind v4 tests. So if you want to go, go ahead and I'll give a review |
That's completely fine! I'll start working on this, I have some free time. If you have any words of wisdom to share on implementing this, feel free to DM me on Slack. Update: 🎊 I've successfully gotten the tests to run without any jest-like dependencies. Next, I need to convert all the Jest syntax. |
See #7623. This reduces our dependency count by hundreds. |
Thank you so much, @avivkeller, @AugustinMauroy and all previous contributors for the immense effort put in here! |
This issue about moving away from Jest to Node.js's Native Test Runner
Why
It would be great if we adopted Node.js's Test Runner (and moved away from Jest) because:
Migration
__mocks__
folders need to be manually imported when used and need to be changed to use the Mocking API https://nodejs.org/api/test.html#mockingjest.
APIs need to be replaced to Node Test Runners APIsexpect
needs to be changed toassert
(https://nodejs.org/api/assert.html)The text was updated successfully, but these errors were encountered: