REGR: using loc to add rows doesn't preserve dtypes #3146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also not ideal, the "upcast by default" assumption is not great for astype(object), and potentially other things. |
Comment on lines
+1600
to
+1610
| df = pd.DataFrame._from_mgr(mgr, axes) | ||
| # operations like loc to append an object row will cast GeometryDtype | ||
| # blocks to object dtype. Try and cast back | ||
| # TODO relying on self here is not ideal pandas#56681 | ||
| for c in self.columns[self.dtypes == "geometry"].intersection(df.columns): | ||
| df[c] = _attempt_ensure_geometry(df[c], crs=self[c].crs) | ||
| if self._geometry_column_name in df.columns: | ||
| try: | ||
| df = df.set_geometry(self._geometry_column_name, crs=self.crs) | ||
| except TypeError: | ||
| pass |
There was a problem hiding this comment.
As a shorter term fix (to just fix the regression for the common case of a "geometry" named columns, and not the longer standing bug), could we just check if the result has a column called "geometry" and in that case try to convert it?
As a way to have something smaller to backport for 0.14.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3119. Alternative to #3125 which I think will not go anywhere.
This is also not an ideal solution.