Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

中国語のREADME_CN.mdを追加。 #100

Merged
merged 5 commits into from
May 9, 2024
Merged

Conversation

xia-mc
Copy link
Contributor

@xia-mc xia-mc commented May 9, 2024

内容

  • README.mdを中国語に翻訳。

変更点

  • README_CN.mdファイルを作成する。

チェックリスト:

  • このリポジトリのコードスタイルに沿っているか
  • 自分自身で動作確認を行ったか、また、それは正常に動作したか

@ringo360
Copy link
Member

ringo360 commented May 9, 2024

Thanks for your contribution!
I'll check now👀

Copy link
Member

@ringo360 ringo360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked your PR!
Thanks! but there are several areas that we would like to see corrected.

README_CN.md Outdated
.setName('hello')
.setDescription('Hello World!'),
execute: async function (interaction) {
await interaction.reply('Hello World!') //処理を記述
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, I would appreciate a translation here as well 📝

README_CN.md Outdated
.setName('hello')
.setDescription('Hello World!'),
execute: async function (interaction) {
await interaction.reply('Hello World!') //処理を記述
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as before

@xia-mc
Copy link
Contributor Author

xia-mc commented May 9, 2024

I checked your PR! Thanks! but there are several areas that we would like to see corrected.

Thanks! I'll fix it now.

@xia-mc xia-mc requested a review from ringo360 May 9, 2024 09:19
Copy link
Member

@ringo360 ringo360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay!

@ringo360
Copy link
Member

ringo360 commented May 9, 2024

I'll merge this PR! 🚀
Thank you for your contribution ❤️

@ringo360 ringo360 merged commit 5e45ffa into TeamSekai:v14-dev May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants