Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textReplace: uh update ig #1936

Closed
wants to merge 43 commits into from
Closed

Conversation

AutumnVN
Copy link
Contributor

@AutumnVN AutumnVN commented Oct 31, 2023

Added:

  • bigger modal
  • merge both type of rule into one with regex toggle
  • convert old data to this new one
  • 2000 char max length
  • realtime update test rule as typing no need to unfocus
  • create new rule button
  • import rules with merge & dedupe
  • export rules
  • rule toggle
  • preview aside after each rule
  • move rule up/down
  • onlyIfIncludes use regex test if it's regex rule

Removed:

  • auto delete empty row
  • auto create last row if not empty

image

AutumnVN and others added 24 commits October 31, 2023 16:10
bigger modal
merge into one with is regex checkbox
move old rules to new rules
longer max length
dont need to unfocus to update test rule anymore
remove auto delete and auto create new rule (it dont work well with this change and annoying)
add new rule button
@Vendicated
Copy link
Owner

so much code in one single file. it'd likely help readability and maintanibility to split it across multiple files

src/components/PluginSettings/PluginModal.tsx Outdated Show resolved Hide resolved
src/components/Switch.tsx Outdated Show resolved Hide resolved
@Vendicated
Copy link
Owner

i'll look at the main textReplace code once it's split across files (or not) as suggested above

src/utils/discord.tsx Outdated Show resolved Hide resolved
@AutumnVN AutumnVN closed this by deleting the head repository May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants