Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Flow icon not visible when scrolled to bottom of page in dark mode #114

Closed
DasAnurag31 opened this issue Jun 5, 2023 · 11 comments
Closed
Assignees
Labels
good first issue Good for newcomers gssoc23

Comments

@DasAnurag31
Copy link

image
@DasAnurag31
Copy link
Author

Can i be assigned this issue ?

@Suvraneel
Copy link
Member

Seems fine. What device are you using? @DasAnurag31
image

@Suvraneel
Copy link
Member

@DasAnurag31 Cool found it...
image
Yeah go ahead. Do not add any background or anything to socials... just make the footer responsive to smaller viewports(ie, >phone(xs,sm) but <~iPad(md))

Also, try to use tailwind queries only instead of stock CSS unless absolutely required

@Aman-Manwani
Copy link
Contributor

@DasAnurag31 Are you still doing this ??

@Aman-Manwani
Copy link
Contributor

@Suvraneel I think it's better to change socials color to white

@DasAnurag31
Copy link
Author

Yes.
I tried out some changes with the background.
I also tried out white, but it did not matchthe colour palette

@DasAnurag31
Copy link
Author

Changing the size of the footer or making it responsive isn't helping. I think we should change the colour of the icons to resolve the issue

@Suvraneel
Copy link
Member

Suvraneel commented Jun 11, 2023

Yes. I tried out some changes with the background. I also tried out white, but it did not matchthe colour palette

Exactly, I agree but changing the colors isn't an option. What can be done is either to make the icons sticky uptill that point where the footer starts OR (a more cool but difficult approach) the orange colored icon can morph to black once it goes on top of footer.

Either way lemme know if any one of you two wanna take it up

@abhinav2712
Copy link
Contributor

Changing the size of the footer or making it responsive isn't helping. I think we should change the colour of the icons to resolve the issue

I feel like its matching:
image

@abhinav2712
Copy link
Contributor

or what we can do it to add a slider background but someone earlier said not to..

nehal-5 added a commit that referenced this issue Apr 30, 2024
updated socialfollow.js : Solves #114
@gurjeetsinghvirdee
Copy link
Collaborator

#131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc23
Projects
None yet
Development

No branches or pull requests

5 participants