Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*) clip open files limit on Darwin #2106

Merged
merged 1 commit into from Jun 7, 2021
Merged

fix(*) clip open files limit on Darwin #2106

merged 1 commit into from Jun 7, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jun 7, 2021

Summary

On Darwin, we have to look at kernel systunes to find the real open
file limit. Rather than adding a lot of extra code for a non-production
platform, just clip it to a sensible default.

Full changelog

N/A

Issues resolved

Fix #2091

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

On Darwin, we have to look at kernel systunes to find the real open
file limit. Rather than adding a lot of extra code for a non-production
platform, just clip it to a sensible default.

This fixes #2091.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner June 7, 2021 00:15
@jpeach jpeach merged commit 4c20ec7 into kumahq:master Jun 7, 2021
@jpeach jpeach deleted the fix/darwin-ulimit-cap branch June 7, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ulimit tests fail on Darwin
2 participants