Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(*) fix flaky test for locality aware loadbalancing #2564

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Locality aware loadbalancing tests were flaky because they were assuming that config is propagated from CP to DP in 0ms.
I've rewritten and moved the test to TrafficRoutes where we have proper test infra to test loadbalancing.

When I did that, I noticed that we have a problem with fair loadbalancing, for which I filed an issue on Github.
The solution is not in the scope of this PR, with this PR I wanted to fix flaky test.

Issues resolved

No issues

Documentation

  • No docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2564 (1e9bf37) into master (94c197e) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
+ Coverage   52.30%   52.35%   +0.05%     
==========================================
  Files         868      868              
  Lines       48296    48281      -15     
==========================================
+ Hits        25261    25278      +17     
+ Misses      20991    20958      -33     
- Partials     2044     2045       +1     
Impacted Files Coverage Δ
test/e2e/deploy/kuma_deploy_universal.go 0.00% <ø> (ø)
.../trafficroute/universal_multizone/traffic_route.go 0.00% <0.00%> (ø)
pkg/insights/resyncer.go 65.81% <0.00%> (+0.85%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/core/resources/manager/cache.go 84.41% <0.00%> (+2.59%) ⬆️
pkg/xds/cache/once/cache.go 94.87% <0.00%> (+7.69%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c197e...1e9bf37. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 2013197 into master Aug 16, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/fix-flaky-test branch August 16, 2021 07:47
mergify bot pushed a commit that referenced this pull request Aug 16, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 2013197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants