Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sparse KNN to use rmm device buffer #3460

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Update sparse KNN to use rmm device buffer #3460

merged 4 commits into from
Feb 23, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Feb 4, 2021

Closes #3377.

@lowener lowener requested a review from a team as a code owner February 4, 2021 17:19
@cjnolet cjnolet added this to PR-WIP in v0.19 Release via automation Feb 5, 2021
viclafargue
viclafargue approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowener lowener changed the base branch from branch-0.18 to branch-0.19 February 12, 2021 15:24
v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 18, 2021
@JohnZed JohnZed added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Feb 23, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7c5a3eb into rapidsai:branch-0.19 Feb 23, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Feb 23, 2021
@lowener lowener deleted the 019-rmm-sparseknn branch February 23, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnZed JohnZed JohnZed approved these changes

@viclafargue viclafargue viclafargue approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcuml non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Update sparse KNN to use rmm device buffer
3 participants
@lowener @JohnZed @viclafargue