Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexibility to copyright checker #3466

Merged
merged 6 commits into from
Feb 25, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Feb 5, 2021

Follow-up to #3453 to expose the file excluder through command-line arguments.

@lowener lowener requested review from a team as code owners February 5, 2021 17:08
@mike-wendt mike-wendt removed the Ops label Feb 18, 2021
@github-actions github-actions bot added gpuCI gpuCI issue and removed Cython / Python Cython or Python issue CMake labels Feb 23, 2021
@JohnZed JohnZed added 4 - Waiting on Reviewer Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 23, 2021
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Two small suggestions. Approving assuming those suggestions get resolved.

ci/checks/copyright.py Outdated Show resolved Hide resolved
ci/checks/copyright.py Outdated Show resolved Hide resolved
lowener and others added 2 commits February 24, 2021 20:07
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error handling is a good improvement, but it doesnt actually take any action when there is an error. I feel like it should immediately return if there is an exception in the regular expression.

ci/checks/copyright.py Outdated Show resolved Hide resolved
ci/checks/copyright.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@codecov-io
Copy link

Codecov Report

Merging #3466 (8419ba6) into branch-0.19 (39c7262) will increase coverage by 9.00%.
The diff coverage is 72.34%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3466      +/-   ##
===============================================
+ Coverage        71.77%   80.77%   +9.00%     
===============================================
  Files              212      225      +13     
  Lines            17075    17617     +542     
===============================================
+ Hits             12256    14231    +1975     
+ Misses            4819     3386    -1433     
Flag Coverage Δ
dask 45.17% <15.78%> (?)
non-dask 72.97% <70.86%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.24% <ø> (-0.30%) ⬇️
python/cuml/experimental/explainer/common.py 88.05% <42.85%> (-4.01%) ⬇️
python/cuml/neighbors/ann.pyx 61.62% <61.62%> (ø)
python/cuml/common/import_utils.py 59.43% <66.66%> (+3.43%) ⬆️
python/cuml/experimental/explainer/base.pyx 67.06% <67.06%> (ø)
python/cuml/metrics/hinge_loss.pyx 73.33% <73.33%> (ø)
python/cuml/neighbors/nearest_neighbors.pyx 92.40% <75.00%> (-0.31%) ⬇️
python/cuml/dask/common/utils.py 43.68% <83.33%> (+16.13%) ⬆️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.80% <100.00%> (+0.29%) ⬆️
python/cuml/experimental/explainer/kernel_shap.pyx 97.75% <100.00%> (+0.48%) ⬆️
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981acb7...8419ba6. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Feb 25, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5e874e9 into rapidsai:branch-0.19 Feb 25, 2021
@lowener lowener deleted the 019-copyright-excluder branch March 14, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond gpuCI gpuCI issue improvement Improvement / enhancement to an existing function libcuml non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants