-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flexibility to copyright checker #3466
Add flexibility to copyright checker #3466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Two small suggestions. Approving assuming those suggestions get resolved.
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error handling is a good improvement, but it doesnt actually take any action when there is an error. I feel like it should immediately return if there is an exception in the regular expression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good.
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3466 +/- ##
===============================================
+ Coverage 71.77% 80.77% +9.00%
===============================================
Files 212 225 +13
Lines 17075 17617 +542
===============================================
+ Hits 12256 14231 +1975
+ Misses 4819 3386 -1433
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@gpucibot merge |
Follow-up to #3453 to expose the file excluder through command-line arguments.