[REVIEW] Use cmake --build in build.sh to facilitate switching build tools #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use cmake --build rather than directly invoking make to better support optional use of other build tools
wphicks
added
feature request
dantegd
approved these changes
Feb 11, 2021
| cd ${LIBCUML_BUILD_DIR} | ||
| make -j${PARALLEL_LEVEL} ${MAKE_TARGETS} VERBOSE=${VERBOSE} ${INSTALL_TARGET} | ||
| build_args="--target ${MAKE_TARGETS} ${INSTALL_TARGET}" |
There was a problem hiding this comment.
I can't remember what is the source of ${INSTALL_TARGET} but isn't it just the word install? What do you think of removing it and just using build_args="--target ${MAKE_TARGETS} install" which is a bit easier to follow
There was a problem hiding this comment.
At line 127, we can potentially suppress installation with the -n flag by setting INSTALL_TARGET="", so I think we still need it, unfortunately.
wphicks
added
the
4 - Waiting on Reviewer
wphicks
changed the title
wphicks
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
cmake --buildin build.sh rather than invokingmakedirectly. This should not affect existing usage at all but will allow developers to build with e.g. Ninja simply by settingCUML_EXTRA_CMAKE_ARGS='-GNinja'when building.