Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward-merger conflicts in #3502 #3506

Merged
merged 4 commits into from
Feb 17, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Feb 16, 2021

This PR fixes the conflicts in #3502

dantegd and others added 4 commits February 16, 2021 18:04
…idsai#3495)

PR does a small change for non project FLASH path of the ci/gpu/build.sh script. We were observing a linking bug in the `test/ml` executable _only_ when it was being executed in the Ubuntu 18.04 containers (see https://gpuci.gpuopenanalytics.com/view/RAPIDS%20-%20GPU%20Matrix/job/rapidsai/job/gpuci/job/cuml/job/branches/job/cuml-gpu-matrix-branch-0.18/)

This PR works around the bug for that particular situation by letting LD_LIBRARY_PATH contain the conda lib folder up to the point of execution of `test/ml`, and does not affect regular project FLASH PR CI.

Authors:
  - Dante Gama Dessavre (@dantegd)

Approvers:
  - Ray Douglass (@raydouglass)

URL: rapidsai#3495
Issues and PRs without activity for 30d will be marked as stale.
If there is no activity for 90d, they will be marked as rotten.

Authors:
  - Jordan Jacobelli (@Ethyling)

Approvers:
  - Dillon Cullinan (@dillon-cullinan)

URL: rapidsai#3500
This PR adds the GitHub action [PR Labeler](https://github.com/actions/labeler) to auto-label PRs based on their content. 

Labeling is managed with a configuration file `.github/labeler.yml` using the following [options](https://github.com/actions/labeler#usage).

Authors:
  - Joseph (@jolorunyomi)

Approvers:
  - Mike Wendt (@mike-wendt)
  - Dante Gama Dessavre (@dantegd)
  - John Zedlewski (@JohnZed)

URL: rapidsai#3407
@dantegd dantegd requested a review from a team as a code owner February 16, 2021 22:29
@dantegd dantegd added this to PR-WIP in v0.19 Release via automation Feb 16, 2021
@github-actions github-actions bot added the Ops label Feb 16, 2021
@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed Ops labels Feb 16, 2021
v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Feb 17, 2021
@dantegd
Copy link
Member Author

dantegd commented Feb 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d5687ea into rapidsai:branch-0.19 Feb 17, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants