Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Additional distance metrics for ANN #3533

Merged
merged 11 commits into from
Mar 19, 2021
Merged

[REVIEW] Additional distance metrics for ANN #3533

merged 11 commits into from
Mar 19, 2021

Conversation

viclafargue
Copy link
Contributor

Answers #2868

@viclafargue viclafargue requested review from a team as code owners February 19, 2021 16:01
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 19, 2021
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Feb 19, 2021
@viclafargue viclafargue changed the title [WIP] Additional distance metrics for ANN [REVIEW] Additional distance metrics for ANN Mar 5, 2021
@viclafargue viclafargue added the 3 - Ready for Review Ready for review by team label Mar 5, 2021
@dantegd dantegd added 2 - In Progress Currenty a work in progress and removed 3 - Ready for Review Ready for review by team labels Mar 8, 2021
@dantegd
Copy link
Member

dantegd commented Mar 10, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 10, 2021

@viclafargue small CI test issue was a very infrequent test being out of the margin of error in one of the SHAP tests, will be tackling that in PR #3596

@viclafargue viclafargue added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Mar 12, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Mar 16, 2021

@lowener could you do review here to start things off?

lowener
lowener requested changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just 2 small remarks.

cpp/src_prims/selection/knn.cuh Outdated Show resolved Hide resolved
python/cuml/neighbors/ann.pyx Show resolved Hide resolved
dantegd
dantegd requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a minor request before merging

cpp/include/cuml/neighbors/knn.hpp Outdated Show resolved Hide resolved
@caryr35 caryr35 added this to PR-WIP in v0.19 Release via automation Mar 18, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v0.19 Release Mar 18, 2021
dantegd
dantegd approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

v0.19 Release automation moved this from PR-Needs review to PR-Reviewer approved Mar 19, 2021
@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 19, 2021
@dantegd
Copy link
Member

dantegd commented Mar 19, 2021

@gpucibot merge

@codecov-io
Copy link

Codecov Report

Merging #3533 (8583337) into branch-0.19 (b388b86) will increase coverage by 0.26%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3533      +/-   ##
===============================================
+ Coverage        80.70%   80.97%   +0.26%     
===============================================
  Files              228      228              
  Lines            17629    17752     +123     
===============================================
+ Hits             14228    14375     +147     
+ Misses            3401     3377      -24
Flag Coverage Δ
dask 45.26% <0.00%> (+0.30%) ⬆️
non-dask 73.25% <88.88%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/neighbors/__init__.py 100.00% <ø> (ø)
python/cuml/neighbors/ann.pyx 90.80% <80.00%> (+29.17%) ⬆️
python/cuml/neighbors/nearest_neighbors.pyx 92.97% <100.00%> (+0.33%) ⬆️
python/cuml/dask/solvers/cd.py 100.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/dask/preprocessing/encoders.py 100.00% <0.00%> (ø)
python/cuml/metrics/_ranking.py 98.57% <0.00%> (+0.02%) ⬆️
python/cuml/preprocessing/encoders.py 95.10% <0.00%> (+0.02%) ⬆️
python/cuml/common/array_descriptor.py 98.24% <0.00%> (+0.03%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b388b86...8583337. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 53a622b into rapidsai:branch-0.19 Mar 19, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Mar 19, 2021
@viclafargue viclafargue mentioned this pull request May 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@lowener lowener lowener approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@viclafargue @dantegd @JohnZed @codecov-io @lowener