Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly invoke make for non-CMake docs target #3534

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Feb 19, 2021

For pydocs target, which invokes a handcrafted Makefile rather than a CMake target, revert to invoking make directly

For pydocs target, which invokes a handcrafted Makefile, revert to
invoking make directly
@wphicks wphicks requested a review from a team as a code owner February 19, 2021 22:51
@wphicks wphicks added 3 - Ready for Review Ready for review by team bug Something isn't working Build or Dep Issues related to building the code or dependencies non-breaking Non-breaking change labels Feb 19, 2021
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@codecov-io
Copy link

Codecov Report

Merging #3534 (e97c665) into branch-0.19 (39c7262) will increase coverage by 7.56%.
The diff coverage is 71.72%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3534      +/-   ##
===============================================
+ Coverage        71.77%   79.33%   +7.56%     
===============================================
  Files              212      225      +13     
  Lines            17075    17946     +871     
===============================================
+ Hits             12256    14238    +1982     
+ Misses            4819     3708    -1111     
Flag Coverage Δ
dask 44.12% <14.67%> (?)
non-dask 71.62% <69.97%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 63.61% <ø> (+0.07%) ⬆️
python/cuml/experimental/explainer/common.py 88.05% <42.85%> (-4.01%) ⬇️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 62.00% <50.00%> (-0.50%) ⬇️
python/cuml/neighbors/nearest_neighbors.pyx 92.43% <50.00%> (-0.29%) ⬇️
python/cuml/neighbors/ann.pyx 61.62% <61.62%> (ø)
python/cuml/common/import_utils.py 59.43% <66.66%> (+3.43%) ⬆️
python/cuml/experimental/explainer/base.pyx 67.06% <67.06%> (ø)
python/cuml/dask/common/utils.py 43.68% <83.33%> (+16.13%) ⬆️
python/cuml/experimental/explainer/kernel_shap.pyx 97.75% <100.00%> (+0.48%) ⬆️
...n/cuml/experimental/explainer/permutation_shap.pyx 98.82% <100.00%> (+0.84%) ⬆️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d393e1e...e97c665. Read the comment docs.

@wphicks wphicks added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Feb 22, 2021
@dantegd
Copy link
Member

dantegd commented Feb 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8e497d0 into rapidsai:branch-0.19 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working Build or Dep Issues related to building the code or dependencies non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants