Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix failing Hellinger gtest #3549

Merged
merged 5 commits into from
Feb 24, 2021
Merged

[REVIEW] Fix failing Hellinger gtest #3549

merged 5 commits into from
Feb 24, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 23, 2021

Closes #3477

@cjnolet cjnolet added bug Something isn't working 3 - Ready for Review Ready for review by team tests Unit testing for project CUDA / C++ CUDA issue non-breaking Non-breaking change labels Feb 23, 2021
@cjnolet cjnolet requested a review from a team as a code owner February 23, 2021 20:44
@cjnolet cjnolet added this to PR-WIP in v0.19 Release via automation Feb 23, 2021
dantegd
dantegd requested changes Feb 23, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just had one comment

cpp/test/prims/sparse/distance.cu Outdated Show resolved Hide resolved
v0.19 Release automation moved this from PR-WIP to PR-Needs review Feb 23, 2021
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Feb 23, 2021
@cjnolet cjnolet added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Feb 23, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Feb 23, 2021

Thanks for reviewing this @dantegd, I just removed the comment.

v0.19 Release automation moved this from PR-Needs review to PR-Reviewer approved Feb 23, 2021
@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Waiting on Reviewer Waiting for reviewer to review or respond labels Feb 23, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Feb 24, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6f06d4b into rapidsai:branch-0.19 Feb 24, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working CUDA / C++ CUDA issue non-breaking Non-breaking change tests Unit testing for project
Projects
No open projects
v0.19 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Gtest failure for Hellinger Distance
2 participants
@cjnolet @dantegd