-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate unnecessary includes discovered by cppclean #3564
Eliminate unnecessary includes discovered by cppclean #3564
Conversation
While this PR does not substantively impact build time, it is the first part of a larger effort to reduce build time. The intention here is not to immediately eliminate all unnecessary includes, just to eliminate those discovered by Before: After: The difference here is not particularly dramatic, in part because this PR does not tackle the more important cases which cannot be immediately addressed with a forward declaration. Those changes are already in progress for the next PR in this series. |
rerun tests |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3564 +/- ##
===============================================
+ Coverage 79.21% 81.00% +1.78%
===============================================
Files 226 227 +1
Lines 17900 17881 -19
===============================================
+ Hits 14180 14485 +305
+ Misses 3720 3396 -324
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, pre-approving, just wanted to leave one question
@gpucibot merge |
Provide forward declarations where possible to reduce unnecessary includes
Eliminate unneeded or redundant includes