Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide "--ccache" flag for build.sh #3566

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Feb 27, 2021

Provide flag to enable ccache for building C, C++, and CUDA code

@wphicks wphicks added feature request New feature or request non-breaking Non-breaking change labels Feb 27, 2021
@wphicks wphicks requested a review from a team as a code owner February 27, 2021 00:58
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Just had a couple of requests

BUILD.md Show resolved Hide resolved
build.sh Outdated Show resolved Hide resolved
@dantegd dantegd added this to PR-WIP in v0.19 Release via automation Mar 1, 2021
@dantegd dantegd added Build or Dep Issues related to building the code or dependencies CMake 4 - Waiting on Author Waiting for author to respond to review labels Mar 1, 2021
@wphicks wphicks added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Mar 8, 2021
@codecov-io
Copy link

Codecov Report

Merging #3566 (169af73) into branch-0.19 (6dfff66) will decrease coverage by 6.12%.
The diff coverage is 94.87%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3566      +/-   ##
===============================================
- Coverage        79.21%   73.09%   -6.13%     
===============================================
  Files              226      214      -12     
  Lines            17900    16977     -923     
===============================================
- Hits             14180    12409    -1771     
- Misses            3720     4568     +848     
Flag Coverage Δ
dask ?
non-dask 73.09% <94.87%> (+1.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/dask/cluster/dbscan.py 48.64% <ø> (-48.58%) ⬇️
python/cuml/dask/linear_model/elastic_net.py 37.50% <ø> (-62.50%) ⬇️
python/cuml/datasets/arima.pyx 97.56% <ø> (ø)
python/cuml/datasets/blobs.py 74.24% <ø> (-3.04%) ⬇️
python/cuml/datasets/regression.pyx 98.11% <ø> (ø)
python/cuml/decomposition/incremental_pca.py 94.70% <ø> (ø)
python/cuml/feature_extraction/_tfidf.py 94.73% <ø> (+0.11%) ⬆️
python/cuml/metrics/pairwise_distances.pyx 98.83% <ø> (ø)
python/cuml/neighbors/__init__.py 100.00% <ø> (ø)
python/cuml/preprocessing/LabelEncoder.py 92.98% <ø> (-1.76%) ⬇️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd9ec89...169af73. Read the comment docs.

v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 9, 2021
@dantegd
Copy link
Member

dantegd commented Mar 9, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ce02064 into rapidsai:branch-0.19 Mar 9, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond Build or Dep Issues related to building the code or dependencies CMake feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants