Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of KMeans #3595

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Mar 9, 2021

Just a small fix of duplicates in KMeans doc.

@lowener lowener requested a review from a team as a code owner March 9, 2021 17:09
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 9, 2021
@lowener lowener added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Mar 9, 2021
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dantegd
Copy link
Member

dantegd commented Mar 9, 2021

@gpucibot merge

@codecov-io
Copy link

Codecov Report

Merging #3595 (4b38b4f) into branch-0.19 (fd9ec89) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3595      +/-   ##
===============================================
+ Coverage        80.70%   80.83%   +0.12%     
===============================================
  Files              227      227              
  Lines            17615    17737     +122     
===============================================
+ Hits             14217    14337     +120     
- Misses            3398     3400       +2     
Flag Coverage Δ
dask 45.30% <ø> (+0.31%) ⬆️
non-dask 73.09% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/cluster/kmeans.pyx 91.95% <ø> (ø)
python/cuml/dask/solvers/cd.py 100.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/dask/preprocessing/encoders.py 100.00% <0.00%> (ø)
python/cuml/metrics/_ranking.py 98.57% <0.00%> (+0.02%) ⬆️
python/cuml/preprocessing/encoders.py 95.10% <0.00%> (+0.02%) ⬆️
python/cuml/common/array_descriptor.py 98.24% <0.00%> (+0.03%) ⬆️
python/cuml/common/array.py 96.99% <0.00%> (+0.04%) ⬆️
python/cuml/dask/common/dask_arr_utils.py 95.83% <0.00%> (+0.05%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd220fc...4b38b4f. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 0967a00 into rapidsai:branch-0.19 Mar 9, 2021
@lowener lowener deleted the 019-fix-kmeans-doc branch March 10, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants