Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix train_test_split with stratify option #3611

Merged
merged 5 commits into from
Mar 26, 2021
Merged

[REVIEW] Fix train_test_split with stratify option #3611

merged 5 commits into from
Mar 26, 2021

Conversation

Nanthini10
Copy link
Contributor

@Nanthini10 Nanthini10 commented Mar 12, 2021 •
edited

The issue was getting rid of a class label while splitting the data, changing the cupy function from array_split to spli mimics the sklearn behavior.

Closes: #3597

Will extend to use any column for stratify instead of just y label -#3623

@Nanthini10 Nanthini10 requested a review from a team as a code owner March 12, 2021 21:53
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 12, 2021
@Nanthini10 Nanthini10 added 2 - In Progress Currenty a work in progress non-breaking Non-breaking change labels Mar 12, 2021
@Nanthini10 Nanthini10 added the bug Something isn't working label Mar 16, 2021
@Nanthini10 Nanthini10 changed the title [WIP] Fix train_test_split with stratify option [REVIEW] Fix train_test_split with stratify option Mar 16, 2021
@Nanthini10 Nanthini10 added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Mar 16, 2021
dantegd
dantegd requested changes Mar 16, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one minor request

python/cuml/model_selection/_split.py Show resolved Hide resolved
@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review Ready for review by team labels Mar 16, 2021
@Nanthini10 Nanthini10 added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels Mar 17, 2021
@Nanthini10 Nanthini10 requested a review from dantegd March 17, 2021 17:32
@caryr35 caryr35 added this to PR-WIP in v0.19 Release via automation Mar 17, 2021
@caryr35 caryr35 moved this from PR-WIP to PR-Needs review in v0.19 Release Mar 17, 2021
v0.19 Release automation moved this from PR-Needs review to PR-Reviewer approved Mar 26, 2021
@dantegd
Copy link
Member

dantegd commented Mar 26, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 23d8302 into rapidsai:branch-0.19 Mar 26, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] train_test_split with stratify=True not working
2 participants
@Nanthini10 @dantegd