[REVIEW] Fixing support for empty rows in sparse Jaccard / Cosine #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
3 - Ready for Review
|
Tagging @lowener for review |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3612 +/- ##
===============================================
- Coverage 80.70% 80.59% -0.12%
===============================================
Files 227 227
Lines 17615 17847 +232
===============================================
+ Hits 14217 14384 +167
- Misses 3398 3463 +65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JohnZed
approved these changes
Mar 15, 2021
| value_t cos = ((norms != 0) * dot) / ((norms == 0) + norms); | ||
|
|
||
| // flip the similarity when both rows are 0 | ||
| bool both_empty = q_norm == 0 && r_norm == 0; |
There was a problem hiding this comment.
nitpick: I'd probably put parens around the == conditions for clarity
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3610