Silhouette Score make_monotonic for non-monotonic label set
#3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
bug
dantegd
requested changes
Mar 16, 2021
| @@ -105,6 +106,16 @@ def _silhouette_coeff( | |||
| labels.to_output(output_type='cupy', output_dtype='int') | |||
| ).shape[0] | |||
|
|
|||
| if not check_labels(labels, cp.arange(n_labels, dtype=np.int32)): | |||
There was a problem hiding this comment.
I think adding a test case that exercises this would be a good idea unless there is one already? Didn't see it on a quick look
There was a problem hiding this comment.
Any suggestions on how to test this without hard-coding some examples?
There was a problem hiding this comment.
Hard-coding is great! Allows you to exactly control the case. Much nicer than just using some big dataset that's hard to debug.
There was a problem hiding this comment.
Thanks! I'll just add the examples in the issue
divyegala
added
4 - Waiting on Reviewer
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3584