-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document model_type='xgboost_json' in FIL #3633
Conversation
rerun tests |
rerun tests |
@gpucibot merge |
rerun tests |
Rerun tests |
The Naive Bayes tests keep failing because the dataset download times out. |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3633 +/- ##
===============================================
+ Coverage 80.72% 81.46% +0.73%
===============================================
Files 228 228
Lines 17629 18087 +458
===============================================
+ Hits 14231 14734 +503
+ Misses 3398 3353 -45
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Closes #3625. Treelite already supports the XGBoost JSON format, so we just need to expose the capability to the FIL loading function too.
Also add
model_type='xgboost_json'
to the FIL testing matrix.