Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document model_type='xgboost_json' in FIL #3633

Merged
merged 3 commits into from
Mar 25, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Mar 18, 2021

Closes #3625. Treelite already supports the XGBoost JSON format, so we just need to expose the capability to the FIL loading function too.

Also add model_type='xgboost_json' to the FIL testing matrix.

@hcho3 hcho3 requested a review from a team as a code owner March 18, 2021 19:35
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 18, 2021
@hcho3 hcho3 added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change doc Documentation labels Mar 18, 2021
@hcho3 hcho3 assigned hcho3 and unassigned hcho3 Mar 18, 2021
@hcho3 hcho3 removed the improvement Improvement / enhancement to an existing function label Mar 18, 2021
@hcho3
Copy link
Contributor Author

hcho3 commented Mar 19, 2021

@hcho3
Copy link
Contributor Author

hcho3 commented Mar 23, 2021

rerun tests

@hcho3 hcho3 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 23, 2021
@hcho3
Copy link
Contributor Author

hcho3 commented Mar 23, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 23, 2021

@gpucibot merge

@hcho3
Copy link
Contributor Author

hcho3 commented Mar 23, 2021

rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Mar 24, 2021

Rerun tests

@hcho3
Copy link
Contributor Author

hcho3 commented Mar 24, 2021

The Naive Bayes tests keep failing because the dataset download times out.

@hcho3
Copy link
Contributor Author

hcho3 commented Mar 24, 2021

rerun tests

@rapids-bot rapids-bot bot merged commit 5a82fdb into rapidsai:branch-0.19 Mar 25, 2021
@codecov-io
Copy link

Codecov Report

Merging #3633 (1bd0a06) into branch-0.19 (14bd6c1) will increase coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3633      +/-   ##
===============================================
+ Coverage        80.72%   81.46%   +0.73%     
===============================================
  Files              228      228              
  Lines            17629    18087     +458     
===============================================
+ Hits             14231    14734     +503     
+ Misses            3398     3353      -45     
Flag Coverage Δ
dask 45.06% <ø> (+0.10%) ⬆️
non-dask 73.91% <ø> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/fil/fil.pyx 93.48% <ø> (+1.65%) ⬆️
python/cuml/dask/solvers/cd.py 100.00% <0.00%> (ø)
python/cuml/pipeline/__init__.py 100.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/neighbors/__init__.py 100.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/dask/preprocessing/encoders.py 100.00% <0.00%> (ø)
python/cuml/metrics/_ranking.py 98.57% <0.00%> (+0.02%) ⬆️
python/cuml/preprocessing/encoders.py 95.10% <0.00%> (+0.02%) ⬆️
python/cuml/common/array_descriptor.py 98.24% <0.00%> (+0.03%) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14bd6c1...1bd0a06. Read the comment docs.

@hcho3 hcho3 deleted the document_xgboost_json branch March 25, 2021 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] ForestInference.load's model_type arg should list xgboost_json as supported model_type
4 participants