Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc, now that FIL supports multi-class classification #3634

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Mar 18, 2021

Closes #3627

@hcho3 hcho3 requested a review from a team as a code owner March 18, 2021 19:43
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 18, 2021
@hcho3 hcho3 added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Mar 18, 2021
@codecov-io
Copy link

Codecov Report

Merging #3634 (f52cbeb) into branch-0.19 (14bd6c1) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3634      +/-   ##
===============================================
+ Coverage        80.72%   80.82%   +0.10%     
===============================================
  Files              228      228              
  Lines            17629    17751     +122     
===============================================
+ Hits             14231    14348     +117     
- Misses            3398     3403       +5     
Flag Coverage Δ
dask 45.27% <ø> (+0.31%) ⬆️
non-dask 73.10% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ython/cuml/dask/ensemble/randomforestclassifier.py 56.25% <ø> (+1.12%) ⬆️
python/cuml/ensemble/randomforestclassifier.pyx 73.40% <ø> (ø)
python/cuml/fil/fil.pyx 91.83% <ø> (ø)
python/cuml/linear_model/linear_regression.pyx 88.23% <0.00%> (-3.53%) ⬇️
python/cuml/dask/solvers/cd.py 100.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/dask/preprocessing/encoders.py 100.00% <0.00%> (ø)
python/cuml/metrics/_ranking.py 98.57% <0.00%> (+0.02%) ⬆️
python/cuml/preprocessing/encoders.py 95.10% <0.00%> (+0.02%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14bd6c1...f52cbeb. Read the comment docs.

Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dantegd
Copy link
Member

dantegd commented Mar 19, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b388b86 into rapidsai:branch-0.19 Mar 19, 2021
@hcho3 hcho3 deleted the update_doc_multiclass branch March 19, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] FIL documentation still says it doesn't support multi-class classification
3 participants