Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc to indicate ExtraTree support #3635

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Mar 18, 2021

Closes #3064.

Treelite supports ExtraTreeRegressor and ExtraTreeClassifier starting from version 1.0.0, so this is just a matter of exposing the capability to FIL.

Also add ExtraTreeRegressor / ExtraTreeClassifier to the FIL test matrix.

@hcho3 hcho3 requested a review from a team as a code owner March 18, 2021 21:15
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 18, 2021
@hcho3 hcho3 added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Mar 18, 2021
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 18, 2021
@dantegd
Copy link
Member

dantegd commented Mar 20, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 20, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c2f246a into rapidsai:branch-0.19 Mar 20, 2021
@codecov-io
Copy link

Codecov Report

Merging #3635 (0de43fe) into branch-0.19 (14bd6c1) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3635      +/-   ##
===============================================
+ Coverage        80.72%   81.08%   +0.35%     
===============================================
  Files              228      228              
  Lines            17629    17877     +248     
===============================================
+ Hits             14231    14495     +264     
+ Misses            3398     3382      -16     
Flag Coverage Δ
dask 45.29% <ø> (+0.33%) ⬆️
non-dask 73.42% <ø> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/fil/fil.pyx 91.83% <ø> (ø)
python/cuml/linear_model/linear_regression.pyx 88.23% <0.00%> (-3.53%) ⬇️
python/cuml/dask/solvers/cd.py 100.00% <0.00%> (ø)
python/cuml/common/numba_utils.py 0.00% <0.00%> (ø)
python/cuml/neighbors/__init__.py 100.00% <0.00%> (ø)
python/cuml/internals/global_settings.py 100.00% <0.00%> (ø)
python/cuml/dask/preprocessing/encoders.py 100.00% <0.00%> (ø)
python/cuml/metrics/_ranking.py 98.57% <0.00%> (+0.02%) ⬆️
python/cuml/preprocessing/encoders.py 95.10% <0.00%> (+0.02%) ⬆️
python/cuml/common/array_descriptor.py 98.24% <0.00%> (+0.03%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14bd6c1...0de43fe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Sklearns' Extra-trees inference in FIL
3 participants