-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Row major Gram matrices #3639
Row major Gram matrices #3639
Conversation
44f8b67
to
edde727
Compare
@tfeher So, your comparison above is only on the gram-matrix kernels and NOT the end-to-end SVM perf, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM.
@tfeher the only thing missing to merge are a couple of updates to copyright years:
|
Yes, the comparison above is only for the kernels. In this PR the row major kernels are not yet used by SVM. |
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3639 +/- ##
===============================================
+ Coverage 80.72% 82.30% +1.58%
===============================================
Files 228 227 -1
Lines 17629 17591 -38
===============================================
+ Hits 14231 14479 +248
+ Misses 3398 3112 -286
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@gpucibot merge |
This PR add row major Gram matrices. These will be used in SVM kernels to allow flexibility in the input layout (#2198).
For the benchmarked cases, row major input is around 2.5% slower on average.