Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SilhouetteScore C++ tests seed #3640

Merged

Conversation

divyegala
Copy link
Member

@divyegala divyegala commented Mar 19, 2021

As @hcho3 noted, a BatchedSilhouetteScore C++ test failed in CI with flakiness. Setting the seed ensures this won't happen

@divyegala divyegala requested review from a team as code owners March 19, 2021 22:06
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Mar 19, 2021
@divyegala divyegala added 5 - DO NOT MERGE Hold off on merging; see PR for details bug Something isn't working CUDA / C++ CUDA issue non-breaking Non-breaking change and removed CUDA/C++ labels Mar 19, 2021
@dantegd
Copy link
Member

dantegd commented Mar 19, 2021

@divyegala since this is not for merging, can you change this to a draft PR?

@divyegala divyegala marked this pull request as draft March 19, 2021 23:03
@divyegala divyegala changed the title [DO NOT MERGE] SilhouetteScore non-monotonic label set CI errors SilhouetteScore C++ tests seed Mar 25, 2021
@divyegala divyegala removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 25, 2021
@divyegala divyegala marked this pull request as ready for review March 25, 2021 23:04
@codecov-io
Copy link

Codecov Report

Merging #3640 (10cb321) into branch-0.19 (fd9ec89) will increase coverage by 0.49%.
The diff coverage is 92.59%.

❗ Current head 10cb321 differs from pull request most recent head f552b0b. Consider uploading reports for the commit f552b0b to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3640      +/-   ##
===============================================
+ Coverage        80.70%   81.20%   +0.49%     
===============================================
  Files              227      228       +1     
  Lines            17615    17869     +254     
===============================================
+ Hits             14217    14511     +294     
+ Misses            3398     3358      -40     
Flag Coverage Δ
dask 45.31% <34.81%> (+0.32%) ⬆️
non-dask 73.28% <92.59%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/cluster/kmeans.pyx 91.95% <ø> (ø)
...ython/cuml/dask/ensemble/randomforestclassifier.py 62.76% <ø> (+6.35%) ⬆️
python/cuml/fil/fil.pyx 92.85% <ø> (+1.02%) ⬆️
python/cuml/neighbors/__init__.py 100.00% <ø> (ø)
python/cuml/preprocessing/encoders.py 95.10% <ø> (+0.02%) ⬆️
python/cuml/common/memory_utils.py 79.26% <50.00%> (+0.15%) ⬆️
python/cuml/neighbors/ann.pyx 90.80% <80.00%> (+29.17%) ⬆️
python/cuml/solvers/qn.pyx 97.20% <85.71%> (-0.43%) ⬇️
python/cuml/linear_model/logistic_regression.pyx 89.16% <88.88%> (+0.20%) ⬆️
python/cuml/ensemble/randomforestclassifier.pyx 73.40% <100.00%> (-0.09%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5f03bf...f552b0b. Read the comment docs.

@divyegala
Copy link
Member Author

@dantegd can you review?

@dantegd
Copy link
Member

dantegd commented Mar 31, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8316807 into rapidsai:branch-0.19 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CUDA / C++ CUDA issue Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants