Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOB access in GLM SoftMax #3642

Merged

Conversation

divyegala
Copy link
Member

closes #3590

@divyegala divyegala requested a review from a team as a code owner March 20, 2021 00:14
@divyegala divyegala added bug Something isn't working CUDA / C++ CUDA issue non-breaking Non-breaking change and removed CUDA/C++ labels Mar 20, 2021
@wphicks wphicks self-assigned this Mar 20, 2021
@codecov-io
Copy link

Codecov Report

Merging #3642 (1db5ad2) into branch-0.19 (fd9ec89) will increase coverage by 0.19%.
The diff coverage is 96.96%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3642      +/-   ##
===============================================
+ Coverage        80.70%   80.90%   +0.19%     
===============================================
  Files              227      228       +1     
  Lines            17615    17752     +137     
===============================================
+ Hits             14217    14362     +145     
+ Misses            3398     3390       -8     
Flag Coverage Δ
dask 45.26% <65.15%> (+0.27%) ⬆️
non-dask 73.07% <96.96%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/cluster/kmeans.pyx 91.95% <ø> (ø)
python/cuml/fil/fil.pyx 91.83% <ø> (ø)
python/cuml/neighbors/__init__.py 100.00% <ø> (ø)
python/cuml/preprocessing/encoders.py 95.10% <ø> (+0.02%) ⬆️
python/cuml/common/memory_utils.py 79.26% <50.00%> (+0.15%) ⬆️
python/cuml/neighbors/ann.pyx 90.80% <80.00%> (+29.17%) ⬆️
...ython/cuml/dask/ensemble/randomforestclassifier.py 56.25% <100.00%> (-0.17%) ⬇️
python/cuml/ensemble/randomforestclassifier.pyx 73.40% <100.00%> (-0.09%) ⬇️
python/cuml/ensemble/randomforestregressor.pyx 75.91% <100.00%> (ø)
python/cuml/metrics/cluster/silhouette_score.pyx 100.00% <100.00%> (+1.81%) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a622b...1db5ad2. Read the comment docs.

Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JohnZed
Copy link
Contributor

JohnZed commented Mar 23, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit af0863d into rapidsai:branch-0.19 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CUDA / C++ CUDA issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid read in logSoftmaxKernel discovered by compute-sanitizer in test_metrics.py
4 participants