Disable three flaky tests #3657
Conversation
hcho3
added
CUDA / C++
| @@ -207,7 +207,8 @@ class silhouetteScoreTest | |||
| //setting test parameter values | |||
| const std::vector<silhouetteScoreParam> inputs = { | |||
| {4, 2, 3, raft::distance::DistanceType::L2Expanded, 4, 0.00001}, | |||
| {4, 2, 2, raft::distance::DistanceType::L2SqrtUnexpanded, 2, 0.00001}, | |||
| // FIXME: temporarily disabled due to flaky test | |||
There was a problem hiding this comment.
If possible could you use GTEST_SKIP so we get a reminder of the number of disabled tests during test runs? (example
Line 1159 in d5687ea
There was a problem hiding this comment.
Not sure if it's doable, since the test is parameterized, and I'm disabling just a single parameterization.
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3657 +/- ##
================================================
- Coverage 80.70% 45.12% -35.59%
================================================
Files 227 224 -3
Lines 17615 17121 -494
================================================
- Hits 14217 7726 -6491
- Misses 3398 9395 +5997
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@gpucibot merge |
adjusted_rand_index/ARI_ii.Result/9: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=10.2,GPU_LABEL=gpu,OS=centos7,PYTHON=3.8/861/consolesilhouetteScore/silhouetteScoreTestClass.Result/1: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=10.1,GPU_LABEL=gpu,OS=ubuntu16.04,PYTHON=3.7/854/consolecuml.test.test_pca.test_pca_defaults[True-300-200]: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cuml/job/prb/job/cuml-gpu-test/CUDA=10.1,GPU_LABEL=gpu,OS=ubuntu16.04,PYTHON=3.7/856/testReport/junit/cuml.test/test_pca/test_pca_defaults_True_300_200_/