Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ninja as default CMake generator #3664

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Mar 26, 2021

Also update documentation with instructions on using alternate generators

Since ccache instructions have already been added to BUILD.md, making this the default should avoid the necessity of any special build tips as discussed in #3544

Close #3544

@wphicks wphicks added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Mar 26, 2021
@wphicks wphicks requested a review from a team as a code owner March 26, 2021 22:09
@wphicks wphicks added this to PR-WIP in v0.19 Release via automation Mar 26, 2021
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 28, 2021
@dantegd
Copy link
Member

dantegd commented Mar 28, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d2ccc92 into rapidsai:branch-0.19 Mar 28, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Development

Successfully merging this pull request may close these issues.

[FEA] Add tips for faster build times to BUILD.md
2 participants