Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda recipes pinning of repo dependencies #3666

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

mike-wendt
Copy link
Contributor

Ensure all conda packages created in this repo that depend on other packages are all version pinned to the same build number. This way it prevents a conda solve from picking mismatched versions of cuml and libcuml that can break this repo during builds and testing.

Ensure all conda packages created in this repo that depend on other packages are all version pinned to the same build number. This way it prevents a conda solve from picking mismatched versions of `cuml` and `libcuml` that can break this repo during builds and testing.
@mike-wendt mike-wendt added bug Something isn't working 3 - Ready for Review Ready for review by team conda conda issue non-breaking Non-breaking change labels Mar 26, 2021
@mike-wendt mike-wendt self-assigned this Mar 26, 2021
@mike-wendt mike-wendt requested a review from a team as a code owner March 26, 2021 22:38
@mike-wendt mike-wendt added this to PR-WIP in v0.19 Release via automation Mar 26, 2021
v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 29, 2021
@dantegd
Copy link
Member

dantegd commented Mar 30, 2021

rerun tests

@dantegd dantegd added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Mar 30, 2021
@mike-wendt mike-wendt changed the title ENH Update conda recipes pinning of repo dependencies Update conda recipes pinning of repo dependencies Mar 30, 2021
@mike-wendt
Copy link
Contributor Author

@dantegd are we good to merge without passing CUDA 11.2 optional tests? These are the CUDA 11.2 tests that I see are failing:

00:32:08.879 [  FAILED  ] 5 tests, listed below:
00:32:08.879 [  FAILED  ] LarsTestFitPredict/0.fitGram, where TypeParam = float
00:32:08.879 [  FAILED  ] LarsTestFitPredict/0.fitX, where TypeParam = float
00:32:08.879 [  FAILED  ] LarsTestFitPredict/1.fitGram, where TypeParam = double
00:32:08.879 [  FAILED  ] LarsTestFitPredict/1.fitX, where TypeParam = double
00:32:08.879 [  FAILED  ] QuasiNewtonTest.binary_logistic_vs_sklearn

@dantegd
Copy link
Member

dantegd commented Mar 30, 2021

@mike-wendt yes it's fine, those tests will be disabled for cuda 11.2 pre update 1 since they were fixed in u1/u2, and don't affect the python level tests.

@dantegd
Copy link
Member

dantegd commented Mar 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit edfba64 into rapidsai:branch-0.19 Mar 30, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Mar 30, 2021
raydouglass added a commit that referenced this pull request Mar 31, 2021
rapids-bot bot pushed a commit that referenced this pull request Mar 31, 2021
ajschmidt8 pushed a commit that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working conda conda issue non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants