-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update conda recipes pinning of repo dependencies #3666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure all conda packages created in this repo that depend on other packages are all version pinned to the same build number. This way it prevents a conda solve from picking mismatched versions of `cuml` and `libcuml` that can break this repo during builds and testing.
mike-wendt
added
bug
Something isn't working
3 - Ready for Review
Ready for review by team
conda
conda issue
non-breaking
Non-breaking change
labels
Mar 26, 2021
raydouglass
approved these changes
Mar 29, 2021
rerun tests |
dantegd
added
5 - Ready to Merge
Testing and reviews complete, ready to merge
and removed
3 - Ready for Review
Ready for review by team
labels
Mar 30, 2021
dantegd
approved these changes
Mar 30, 2021
mike-wendt
changed the title
ENH Update conda recipes pinning of repo dependencies
Update conda recipes pinning of repo dependencies
Mar 30, 2021
@dantegd are we good to merge without passing CUDA 11.2 optional tests? These are the CUDA 11.2 tests that I see are failing:
|
@mike-wendt yes it's fine, those tests will be disabled for cuda 11.2 pre update 1 since they were fixed in u1/u2, and don't affect the python level tests. |
@gpucibot merge |
raydouglass
added a commit
that referenced
this pull request
Mar 31, 2021
This reverts commit edfba64.
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 31, 2021
Reverts #3666 Authors: - Ray Douglass (https://github.com/raydouglass) Approvers: - Mike Wendt (https://github.com/mike-wendt) URL: #3680
ajschmidt8
pushed a commit
that referenced
this pull request
Feb 13, 2023
This reverts commit d05b2b9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
bug
Something isn't working
conda
conda issue
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all conda packages created in this repo that depend on other packages are all version pinned to the same build number. This way it prevents a conda solve from picking mismatched versions of
cuml
andlibcuml
that can break this repo during builds and testing.