[REVIEW] Deprecating quantile-per-tree and removing three previously deprecated Random Forest parameters #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
vinaydes
changed the title
JohnZed
approved these changes
Mar 30, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks
quantile-per-treeparameter of Random Forest for deprecation. Enabling quantile computation per tree has significant performance impact without much accuracy gain. Similar levels of accuracy can be achieved with higher number of bins for global quantiles. Therefore this feature would be removed from subsequent release.This PR also removes three previously deprecated RF parameters:
seedwas deprecated in 0.16 and was planed to be removed in 0.17min_rows_per_nodewas deprecated in 0.17 and was planed to be removed in 0.18rows_samplewas deprecated in 0.17 and was planed to be removed 0.18Also minor correction in documentation.