Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests that fail on CUDA 11.2 #3679

Merged
merged 5 commits into from
Apr 1, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Mar 31, 2021

No description provided.

@dantegd dantegd added bug Something isn't working 3 - Ready for Review Ready for review by team tests Unit testing for project non-breaking Non-breaking change labels Mar 31, 2021
@dantegd dantegd added this to PR-WIP in v0.19 Release via automation Mar 31, 2021
@dantegd dantegd requested a review from a team as a code owner March 31, 2021 17:14
v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Mar 31, 2021
Copy link
Member

@teju85 teju85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging:

  1. @vinaydes, @venkywonka and @hcho3 for the 11.2 batched-level-algo unit-test failures
  2. @tfeher for the lars and qn solver unit-test failures

For the next release, we should root-cause and fix these tests.

However, for this release, I'm ok skipping these. Approving.

@JohnZed
Copy link
Contributor

JohnZed commented Mar 31, 2021

@teju85 - thanks! We also plan to continue diagnosing within burndown period. No pytests fail, though, and these are fairly small corner cases.

@dantegd
Copy link
Member Author

dantegd commented Mar 31, 2021

@teju85 @vinaydes @venkywonka @hcho3 and @tfeher the failures are being tracked in #3406 (lars test for example seems to work perfectly fine in update 1 and 2)

@dantegd dantegd changed the title Skip C++ tests that fail on CUDA 11.2 Skip tests that fail on CUDA 11.2 Mar 31, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 31, 2021
@dantegd
Copy link
Member Author

dantegd commented Mar 31, 2021

The ARIMA Pytests also have failures with nan, being tracked in #3649

@dantegd dantegd requested a review from a team as a code owner March 31, 2021 22:41
@JohnZed
Copy link
Contributor

JohnZed commented Mar 31, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7d72109 into rapidsai:branch-0.19 Apr 1, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Apr 1, 2021
achirkin added a commit to achirkin/cuml that referenced this pull request May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change tests Unit testing for project
Projects
No open projects
v0.19 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants