-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIL and Dask demo #3698
FIL and Dask demo #3698
Conversation
miroenev
commented
Apr 1, 2021
- Replaced numpy with cupy, and sklearn with cuml (e.g., data generation and splitting)
- Resized XGBoost model params from 15 trees at 25 max_depth, to 100 trees at 20 max_depth
- Added Dask distributed data generation, FIL model loading on worker init, and distributed FIL prediction
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice demo! I'm going to be referring to this one a lot in the future.
A few small items in comments. The only overall thing is don't forget to clear outputs before you finalize the PR to allow this to be run in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last formatting thing in comments, but this LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Think the cell outputs came back
That was odd, should be cleared now. thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #3698 +/- ##
===============================================
+ Coverage 80.70% 82.94% +2.23%
===============================================
Files 227 227
Lines 17615 17726 +111
===============================================
+ Hits 14217 14702 +485
+ Misses 3398 3024 -374
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@gpucibot merge |