Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparse docstring comments #3712

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

JohnZed
Copy link
Contributor

@JohnZed JohnZed commented Apr 5, 2021

Closes #3607

Uses the docstring generator to flag a few more algorithms that can consume sparse inputs.
Grepped for all uses of is_sparse in algorithms to find candidates.

@JohnZed JohnZed requested a review from a team as a code owner April 5, 2021 15:47
@JohnZed JohnZed added this to PR-WIP in v0.19 Release via automation Apr 5, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 5, 2021
@JohnZed JohnZed added doc Documentation non-breaking Non-breaking change labels Apr 5, 2021
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm couldn't find any other missing sparse docstrings

v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Apr 5, 2021
@dantegd
Copy link
Member

dantegd commented Apr 5, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Apr 5, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4a024f9 into rapidsai:branch-0.19 Apr 6, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Development

Successfully merging this pull request may close these issues.

[DOC] Ensure that all docstrings list when sparse inputs supported
2 participants