Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix random state generator #3716

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

viclafargue
Copy link
Contributor

Answers #3692

@viclafargue viclafargue requested a review from a team as a code owner April 6, 2021 14:47
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 6, 2021
@viclafargue viclafargue added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Apr 6, 2021
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnZed
Copy link
Contributor

JohnZed commented Apr 6, 2021

Thank you to @frankier for the original version of this in #3644! We'll merge this one as the other PR got hung up on some merge issues

@JohnZed
Copy link
Contributor

JohnZed commented Apr 6, 2021

rerun tests

@codecov-io
Copy link

Codecov Report

Merging #3716 (6fea88a) into branch-0.19 (fd9ec89) will increase coverage by 2.21%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3716      +/-   ##
===============================================
+ Coverage        80.70%   82.92%   +2.21%     
===============================================
  Files              227      227              
  Lines            17615    17586      -29     
===============================================
+ Hits             14217    14583     +366     
+ Misses            3398     3003     -395     
Flag Coverage Δ
dask 45.30% <ø> (+0.31%) ⬆️
non-dask 74.94% <ø> (+2.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/__init__.py 95.58% <ø> (+0.20%) ⬆️
...cuml/_thirdparty/sklearn/preprocessing/__init__.py 100.00% <ø> (ø)
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 64.27% <ø> (+1.16%) ⬆️
...hirdparty/sklearn/preprocessing/_discretization.py 83.33% <ø> (-0.88%) ⬇️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 85.54% <ø> (+22.74%) ⬆️
python/cuml/_thirdparty/sklearn/utils/extmath.py 56.89% <ø> (ø)
...cuml/_thirdparty/sklearn/utils/skl_dependencies.py 79.54% <ø> (+25.62%) ⬆️
...ython/cuml/_thirdparty/sklearn/utils/validation.py 18.41% <ø> (-4.04%) ⬇️
python/cuml/cluster/__init__.py 100.00% <ø> (ø)
python/cuml/cluster/agglomerative.pyx 96.47% <ø> (ø)
... and 155 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9feecfb...6fea88a. Read the comment docs.

@JohnZed
Copy link
Contributor

JohnZed commented Apr 7, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d87704b into rapidsai:branch-0.19 Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants