Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Updating docs, readme, and umap param tests for 0.19 #3731

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Apr 8, 2021

No description provided.

@cjnolet cjnolet requested a review from a team as a code owner April 8, 2021 17:04
@cjnolet cjnolet added the non-breaking Non-breaking change label Apr 8, 2021
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function and removed CUDA/C++ labels Apr 8, 2021
@cjnolet cjnolet added this to PR-WIP in v0.19 Release via automation Apr 8, 2021
v0.19 Release automation moved this from PR-WIP to PR-Reviewer approved Apr 8, 2021
@JohnZed
Copy link
Contributor

JohnZed commented Apr 8, 2021

@gpucibot merge

@codecov-io
Copy link

Codecov Report

Merging #3731 (f44469c) into branch-0.19 (fd9ec89) will increase coverage by 5.24%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3731      +/-   ##
===============================================
+ Coverage        80.70%   85.95%   +5.24%     
===============================================
  Files              227      225       -2     
  Lines            17615    16987     -628     
===============================================
+ Hits             14217    14601     +384     
+ Misses            3398     2386    -1012     
Flag Coverage Δ
dask 48.96% <ø> (+3.97%) ⬆️
non-dask 77.79% <ø> (+4.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/__init__.py 95.58% <ø> (+0.20%) ⬆️
...cuml/_thirdparty/sklearn/preprocessing/__init__.py 100.00% <ø> (ø)
...on/cuml/_thirdparty/sklearn/preprocessing/_data.py 67.22% <ø> (+4.10%) ⬆️
...hirdparty/sklearn/preprocessing/_discretization.py 83.33% <ø> (-0.88%) ⬇️
...l/_thirdparty/sklearn/preprocessing/_imputation.py 85.54% <ø> (+22.74%) ⬆️
python/cuml/_thirdparty/sklearn/utils/extmath.py 97.22% <ø> (+40.32%) ⬆️
...cuml/_thirdparty/sklearn/utils/skl_dependencies.py 79.54% <ø> (+25.62%) ⬆️
...thon/cuml/_thirdparty/sklearn/utils/sparsefuncs.py 90.90% <ø> (+48.32%) ⬆️
...ython/cuml/_thirdparty/sklearn/utils/validation.py 64.10% <ø> (+41.65%) ⬆️
python/cuml/benchmark/algorithms.py 94.38% <ø> (ø)
... and 166 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1838ff2...f44469c. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 0fe729d into rapidsai:branch-0.19 Apr 8, 2021
v0.19 Release automation moved this from PR-Reviewer approved to Done Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
No open projects
v0.19 Release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants