Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use url module #4

Closed
wants to merge 2 commits into from
Closed

Conversation

mtfoley
Copy link

@mtfoley mtfoley commented Jul 12, 2022

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

README update and different require for endpoint config. Just reflects what I needed to do in order to get this running locally.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❀️! πŸŽ‰πŸ•
Say hello by joining the conversation in our Discord

@mtfoley
Copy link
Author

mtfoley commented Jul 13, 2022

@0-vortex I've been doing some other poking around and found that if I seed locally from what's in the open-sauced/actions/hot-supabase directory, I have to drop the repos/users foreign key constraint.

Also, when I do supabase db reset and the seed.sql file gets used, the data doesn't make it into the tables and I wonder if something similar is going on.

@0-vortex
Copy link
Contributor

@0-vortex I've been doing some other poking around and found that if I seed locally from what's in the open-sauced/actions/hot-supabase directory, I have to drop the repos/users foreign key constraint.

Also, when I do supabase db reset and the seed.sql file gets used, the data doesn't make it into the tables and I wonder if something similar is going on.

are you running supabase locally? otherwise you are juggling between adjusting the dev or the prod db, both things which shouldn't do right now as the entire structure should sit in the backend rather than actions.

To figure out if the seeds are broken just run them manually in supabase ui 😁

@mtfoley
Copy link
Author

mtfoley commented Jul 13, 2022

Yeah, I'm running it locally. i saw the docker containers pull and spin up, and i saw the supabase/seed.sql file get used. however, in the studio, the tables are empty. i realize now, the shell script to download copies of the SQL files from the actions repo was unnecessary, but i still wonder if we should troubleshoot why that initial seed file didn't fill up the db locally.

@0-vortex
Copy link
Contributor

Yeah, I'm running it locally. i saw the docker containers pull and spin up, and i saw the supabase/seed.sql file get used. however, in the studio, the tables are empty. i realize now, the shell script to download copies of the SQL files from the actions repo was unnecessary, but i still wonder if we should troubleshoot why that initial seed file didn't fill up the db locally.

Sorry for the late reply - the seed file is being executed via psql inside the docker containers, similarly to what we are doing in the seed.sh script, hence the errors are not visible unless you check the process logs after you sh into the containers.
You can check the error yourself simply by renaming seed.sql and running it locally as described above, however the most likely culprit is bad insert order, conflicting with relationships, running the individual seed files in the logical order would fix this (i normally seed it this way and then adjust script in actions, however we are partially divergent until backend is deployed fully)

@0-vortex
Copy link
Contributor

We are moving off of this system for seeding, will close this :D

@0-vortex 0-vortex closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants