Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No python3 support #1

Closed
pjz opened this issue Jul 25, 2016 · 5 comments
Closed

No python3 support #1

pjz opened this issue Jul 25, 2016 · 5 comments
Assignees

Comments

@pjz
Copy link

pjz commented Jul 25, 2016

Any chance you want to upgrade this to support python3?

@0101
Copy link
Owner

0101 commented Jul 28, 2016

Sure, I'll look into it.

Seems like there's been an attempt already but it wasn't finished: https://github.com/Arnie97/pipetools/commits/plain

@Arnie97 did you sober up yet? :)

@0101 0101 self-assigned this Jul 28, 2016
@Arnie97
Copy link
Contributor

Arnie97 commented Jul 29, 2016

@0101 https://github.com/Arnie97/pipetools/commits/plain is now abandoned.
I've restarted my work at https://github.com/Arnie97/pipetools/commits/master.

Todo:

  • Pass all unit tests
  • Fix Travis-CI (It reported passing whether tests were passed or not)
  • Make sure symbols imported from pipetools.compat does not pollute the global namespace
  • Update doctests
  • Update reStructuredText docs

@0101
Copy link
Owner

0101 commented Aug 1, 2016

@Arnie97 thanks! Let me know if you need any help.

The problem with XObject being unhashable could probably be fixed by explicitly defining __hash__ on it:

def __hash__(self):
    return super(XObject, self).__hash__()

I'm not 100 % sure it won't cause trouble in some edge case with __eq__ being defined the way it is. Although probably this is how it worked in Python 2 all this time :)

@0101
Copy link
Owner

0101 commented Aug 3, 2016

Version 0.3 with Python 3 support is now on PyPI. Thanks @Arnie97 for doing the work! (And also for fixing Travis :)

@0101 0101 closed this as completed Aug 3, 2016
@pjz
Copy link
Author

pjz commented Aug 3, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants